Skip to content

feat: Add ThrottledInvoker utility#300

Merged
bnbajwa merged 1 commit intoreactivemarkets:masterfrom
bnbajwa:util
Oct 9, 2025
Merged

feat: Add ThrottledInvoker utility#300
bnbajwa merged 1 commit intoreactivemarkets:masterfrom
bnbajwa:util

Conversation

@bnbajwa
Copy link
Copy Markdown
Contributor

@bnbajwa bnbajwa commented Oct 8, 2025

Common use case is throttling logging.

SDB-9266

@bnbajwa bnbajwa requested a review from a team as a code owner October 8, 2025 20:08
@gemini-code-assist
Copy link
Copy Markdown

gemini-code-assist bot commented Oct 8, 2025

Summary of Changes

Hello @bnbajwa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR introduces a ThrottledInvoker utility class for rate-limiting function calls, particularly useful for scenarios like logging. It includes the new class definition in Utility.hpp and a comprehensive unit test in Utility.ut.cpp to validate its behavior.

Highlights

  • Intent: This pull request introduces a new ThrottledInvoker utility class to provide a mechanism for rate-limiting function calls. The primary use case mentioned is throttling logging, addressing issue SDB-9266.
  • Changes: The core change is the addition of a ThrottledInvoker template class in toolbox/util/Utility.hpp. This class allows a callable to be invoked only if a specified cooldown_interval has passed since its last invocation. It uses ClockT and DurationT for generic time handling. A corresponding unit test, ThrottledInvokerCheck, has been added to toolbox/util/Utility.ut.cpp to verify its functionality, ensuring that the callable is invoked only once within the cooldown period and then again after the period has elapsed.
  • Reviewer Activity: No specific reviewer activity has been recorded or provided in the context for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 8, 2025
View reviewed changes
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Thank you for adding the ThrottledInvoker utility. This is a useful component for cases like logging. I've reviewed the changes and have a few suggestions to improve correctness, maintainability, and documentation. My main points are about ensuring the first invocation always happens and improving the test structure. Please see my detailed comments below.

@bnbajwa bnbajwa closed this Oct 8, 2025
@bnbajwa bnbajwa reopened this Oct 8, 2025
@bnbajwa bnbajwa force-pushed the util branch 2 times, most recently from c2abc37 to f51ba4b Compare October 8, 2025 22:00
@reactivemarkets reactivemarkets deleted a comment from gemini-code-assist bot Oct 8, 2025
@bnbajwa bnbajwa force-pushed the util branch 2 times, most recently from 7da2690 to edea8e8 Compare October 8, 2025 23:04
Shivix
Shivix reviewed Oct 9, 2025
View reviewed changes
@bnbajwa bnbajwa force-pushed the util branch 2 times, most recently from 7bcc990 to 9382d93 Compare October 9, 2025 08:37
Shivix
Shivix reviewed Oct 9, 2025
View reviewed changes
@bnbajwa
feat: Add ThrottledInvoker utility
2a7fd37 
Common use case is throttling logging.

SDB-9889
Shivix
Shivix approved these changes Oct 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Shivix Shivix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bnbajwa bnbajwa merged commit a72480a into reactivemarkets:master Oct 9, 2025
5 checks passed
@bnbajwa bnbajwa deleted the util branch October 9, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shivix Shivix Shivix approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bnbajwa @Shivix